make widget_create() fail on frame widgets if screen_create() fails

2008-12-14 09:54:13 +00:00
parent 52f8121ba5
commit 4b11c5aa17
1 changed files with 7 additions and 0 deletions
@@ -123,6 +123,13 @@ widget_create(char *id, WidgetType type, Screen *screen)
 		strcat(frame_name, id);

 		w->frame_screen = screen_create(frame_name, screen->client);
+		if (w->frame_screen == NULL) {
+			report(RPT_DEBUG, "%s: Error allocating", __FUNCTION__);
+			free(w->id);
+			free(w);
+			/* return NULL after cleaning up */
+			w = NULL;
+		}

 		free(frame_name); /* not needed anymore */
 	}