Cfontz: Fix display of bars and output a warning on startup if driver was

not compiles with SEAMLESS_HBARS (hbars will not display correctly then). Also
update User's Guide.

ChangeLog

@@ -8,8 +8,6 @@ Key:
 v0.5dev (ongoing development)
  - Remove deprecated CFontz633 driver. Use CFontzPacket with Model=633 instead!
  + new driver: glcd unified graphic display driver (M. Dolze)
- * curses: Fix missed keystrokes (from Debian)
- * curses: Correct the name of the info function.
  + new driver: vlsys_m428 driver for Moneual MonCaso 320 (W. Hauck)
  * hd44780/serial: Fix handling of keys for LoS-Panel (M. Kirchner)
  * hd44780/serial: Change backlight handling (see commit message)
@@ -47,6 +45,10 @@ v0.5.5
  + Build system: --enable-extra-charmaps option adds language specific charmaps
  * imonlcd: Fix spinning of disc icon (E. Pooch)
  * SureElec: Change port initialization (SF 3212891)
+ * curses: Fix missed keystrokes (from Debian)
+ * curses: Correct the name of the info function.
+ * Update LCDd.conf to be better understood by Config::Model (D. Dumont)
+ * CFontz: Fix display of bars
 
 v0.5.4
  * Update driver includes and LDFLAGS (fixed glk and bayrad binding error)

docs/lcdproc-user/drivers/CFontz.docbook

@@ -6,6 +6,15 @@ This section talks about using LCDproc with the serial LCD displays of the
 CFA632 and CFA634 series by CrystalFontz, Inc.
 </para>
 
+<important>
+  <para>
+    This driver must be compiled with SEAMLESS_HBARS option enabled. Otherwise
+    horizontal bars will not display correctly. Use
+    <command>configure --enable-driver=CFontz --enable-seamless-hbars</command>
+    to accomplish this.
+  </para>
+</important>
+
 <sect2 id="CFontz-config">
 <title>Configuration in LCDd.conf</title>
 
@@ -43,7 +52,7 @@ CFA632 and CFA634 series by CrystalFontz, Inc.
     Set the initial contrast.
     Legal values for <replaceable>CONTRAST</replaceable> are in the range
     between <literal>0</literal> and <literal>1000</literal>.
-    If not given, it defaults to <literal>140</literal>.
+    If not given, it defaults to <literal>560</literal>.
   </para></listitem>
 </varlistentry>
 
@@ -97,7 +106,7 @@ CFA632 and CFA634 series by CrystalFontz, Inc.
     <property>NewFirmware</property> = &parameters.yesnodef;
   </term>
   <listitem><para>
-    Set the firmware version (<emphasis>New</emphasis> means >= 2.0) [default: <literal>no</literal>; legal: <literal>yes</literal>, <literal>no</literal>]
+    Set the firmware version (<emphasis>New</emphasis> means >= 2.0) [default: <literal>no</literal>; legal: <literal>yes</literal>, <literal>no</literal>].
   </para></listitem>
 </varlistentry>
 
@@ -107,7 +116,7 @@ CFA632 and CFA634 series by CrystalFontz, Inc.
   </term>
   <listitem><para>
     Reinitialize the LCD's BIOS [default: <literal>no</literal>; legal: <literal>yes</literal>, <literal>no</literal>]
-    normally you shouldn't need this
+    normally you shouldn't need this.
   </para></listitem>
 </varlistentry>
 </variablelist>

docs/lcdproc-user/lcdproc-user.css

@@ -3,7 +3,7 @@ pre.screen {
   border: 1px solid #006600 ;
 }
 
-div.note, div.tip, div.warning {
+div.note, div.tip, div.warning, div.important {
   margin-top: 5px;
   margin-bottom: 5px;
   padding: 5px;
@@ -13,6 +13,9 @@ div.note, div.tip {
   border-left: solid palegreen 20px;
 }
 
+div.important {
+  border-left: solid gold 20px;
+}
 div.warning {
   border-left: solid red 20px;
 }

server/drivers/CFontz.c

@@ -243,6 +243,12 @@ CFontz_init(Driver *drvthis)
 		report(RPT_INFO, "%s: rebooting LCD...", drvthis->name);
 		CFontz_reboot(drvthis);
 	}
+
+#ifndef SEAMLESS_HBARS
+	report(RPT_WARNING, "%s: driver built without SEAMLESS_HBARS. "
+	       "Hbars will NOT display correctly!", drvthis->name);
+#endif
+
 	sleep (1);
 	CFontz_hidecursor(drvthis);
 	CFontz_linewrap(drvthis, 1);
@@ -916,7 +922,7 @@ CFontz_icon(Driver *drvthis, int x, int y, int icon)
 	/* Yes we know, this is a VERY BAD implementation :-) */
 	switch (icon) {
 		case ICON_BLOCK_FILLED:
-			CFontz_raw_chr(drvthis, x, y, (p->newfirmware) ? 214 : 255);
+			CFontz_raw_chr(drvthis, x, y, (p->newfirmware) ? 0x1F : 255);
 			break;
 		case ICON_HEART_FILLED:
 			CFontz_set_char(drvthis, 0, heart_filled);