mangavalk/lcdproc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add note about necessary review of render_string (don't have the time right now).

Browse Source
This commit is contained in:
mmdolze
2011-01-24 19:46:06 +00:00
parent 224eca976a
commit 95512f591d
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/render.c
+8
View File
@@ -15,6 +15,8 @@
* NOTE: (from David Douthitt) Multiple screen sizes? Multiple simultaneous * NOTE: (from David Douthitt) Multiple screen sizes? Multiple simultaneous
* screens? Horrors of horrors... next thing you know it'll be making coffee... * screens? Horrors of horrors... next thing you know it'll be making coffee...
* Better believe it'll take a while to do... * Better believe it'll take a while to do...
*
* \todo Review render_string for correctness.
*/ */
/* This file is part of LCDd, the lcdproc server. /* This file is part of LCDd, the lcdproc server.
@@ -308,6 +310,12 @@ render_string(Widget *w, int left, int top, int right, int bottom, int fy)
int length; int length;
char str[BUFSIZE]; char str[BUFSIZE];
/*
* FIXME: Could be a bug here? w->x is recalculated (On first
* call only? Is it preserved between calls?) and first
* character of w->text shows up on the rightmost column for
* strings totally off-screen. Is this on purpose? (M. Dolze)
*/
w->x = min(w->x, right - left); w->x = min(w->x, right - left);
length = min(right - left - w->x + 1, sizeof(str)-1); length = min(right - left - w->x + 1, sizeof(str)-1);
strncpy(str, w->text, length); strncpy(str, w->text, length);