From 6d41e71f334237d92c12ed7995b51335524eee53 Mon Sep 17 00:00:00 2001
From: robijn <robijn@users.sourceforge.net>
Date: Sun, 24 Mar 2002 19:28:50 +0000
Subject: [PATCH] Fixed 4bit enable lines bug.

---
 server/drivers/hd44780-4bit.c | 12 ++++++++----
 server/drivers/hd44780.c      |  4 ----
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/server/drivers/hd44780-4bit.c b/server/drivers/hd44780-4bit.c
index e6f4e42..a8eba30 100644
--- a/server/drivers/hd44780-4bit.c
+++ b/server/drivers/hd44780-4bit.c
@@ -197,10 +197,14 @@ lcdstat_HD44780_senddata (PrivateData *p, unsigned char displayID, unsigned char
 	portControl |= p->backlight_bit;
 
 	if (displayID <= 3) {
-		if (displayID == 0)
-			enableLines = EnMask[0] | EnMask[1] | EnMask[2];
-		else
+		if (displayID == 0) {
+			enableLines = EnMask[0] | EnMask[1];
+			if (p->extIF) {
+				enableLines |= EnMask[2];
+			}
+		} else {
 			enableLines = EnMask[displayID - 1];
+		}
 
 		port_out (p->port, portControl | h);
 		if( p->delayBus ) p->hd44780_functions->uPause (p, 1);
@@ -237,7 +241,7 @@ lcdstat_HD44780_senddata (PrivateData *p, unsigned char displayID, unsigned char
 
 void lcdstat_HD44780_backlight (PrivateData *p, unsigned char state)
 {
-	p->backlight_bit = (state?0:0x20);	// D5 line
+	p->backlight_bit = ((!p->have_backlight||state)?0:BL);
 
 	port_out (p->port, p->backlight_bit);
 }
diff --git a/server/drivers/hd44780.c b/server/drivers/hd44780.c
index 4d8e7b1..8f7d922 100644
--- a/server/drivers/hd44780.c
+++ b/server/drivers/hd44780.c
@@ -242,10 +242,6 @@ HD44780_init (Driver * drvthis, char *args)
 	memset(p->cc_buf, 0, NUM_CCs * p->cellheight);
 	memset(p->cc_dirty, 1, NUM_CCs); /* all custom chars dirty */
 
-	// Backlight ?
-	if ( p->have_backlight ) {
-		drvthis->backlight = HD44780_backlight;
-	}
 	// Keypad ?
 	if ( p->have_keypad ) {
 		int x, y;