mangavalk/lcdproc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix a bug not checking for keypad rows 7-10 in hd44780-4bit correctly.

Browse Source
This commit is contained in:
mmdolze
2009-12-12 21:32:31 +00:00
parent 6161df5b60
commit 1971f0ccee
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ChangeLog
+1
View File
@@ -15,6 +15,7 @@ v.0.5dev (ongoing development)
* picolcd driver: Fix RC-5 for picoLCD 20x2 (A. van Schie) * picolcd driver: Fix RC-5 for picoLCD 20x2 (A. van Schie)
* Introduce shared/defines.h to collect commonly used macros * Introduce shared/defines.h to collect commonly used macros
+ new driver: SureElec for devices made by SURE Electronics (Laurent Latil) + new driver: SureElec for devices made by SURE Electronics (Laurent Latil)
* hd44780-4bit: Fix bug not checking for keypad rows 7-10 correctly
v0.5.3 v0.5.3
+ lcdexec: notification when called program finishes + lcdexec: notification when called program finishes
server/drivers/hd44780-4bit.c
+2 -2
View File
@@ -261,7 +261,7 @@ void lcdstat_HD44780_backlight(PrivateData *p, unsigned char state)
/** /**
* Read keypress. * Read keypress.
* \param p Pointer to driver's private data structure. * \param p Pointer to driver's private data structure.
* \param YData ??? * \param YData Bitmap of rows / lines to enable.
* \return Bitmap of the pressed keys. * \return Bitmap of the pressed keys.
*/ */
unsigned char lcdstat_HD44780_readkeypad(PrivateData *p, unsigned int YData) unsigned char lcdstat_HD44780_readkeypad(PrivateData *p, unsigned int YData)
@@ -273,7 +273,7 @@ unsigned char lcdstat_HD44780_readkeypad(PrivateData *p, unsigned int YData)
port_out(p->port, ~YData & 0x003F); port_out(p->port, ~YData & 0x003F);
if (p->numDisplays<=3) { if (p->numDisplays<=3) {
// Can't combine >3 displays with >6 keypad output lines // Can't combine >3 displays with >6 keypad output lines
port_out(p->port + 2, (((~YData & 0x03C0) << 6)) ^ OUTMASK); port_out(p->port + 2, (((~YData & 0x03C0) >> 6)) ^ OUTMASK);
} }
if (p->delayBus) p->hd44780_functions->uPause(p, 1); if (p->delayBus) p->hd44780_functions->uPause(p, 1);